search

ausocean / av

Other
0 stars 0 forks source link

Generalized Makefile #29

Closed scruzin closed 4 months ago

scruzin commented 4 months ago

The Makefile has been generalized so that it can install all clients.

Usage is as follows:

make BIN=rv CT=camera ...
make BIN=rv CT=hydrophone ...
make BIN=speaker CT=speaker SVC=wifi-off-delay ...

For backwards compatibility, just calling make is equivalent to make BIN=rv CT=camera

trekhopton commented 4 months ago

The Speaker makefile had some features that were useful for image creation. The SET_MAC and CONFIG flags gave us the ability to not perform device specific actions for image creation. I think after this big period of changing the installation process we should review the image creation process to streamline it. Perhaps it's just a guide of what files to copy where, but if we can automate parts of it we should.

scruzin commented 4 months ago

The Speaker makefile had some features that were useful for image creation. The SET_MAC and CONFIG flags gave us the ability to not perform device specific actions for image creation. I think after this big period of changing the installation process we should review the image creation process to streamline it. Perhaps it's just a guide of what files to copy where, but if we can automate parts of it we should.

It's easy enough to have optional make targets, and easier to maintain that multiple make files. For example, I added the optional SVC for the wifi service.

Anyway, I think we already have the functionality needed:

The set_conf_target is now obsolete, since it is handled by the package installer. And it is possible to not set the MAC by just calling make install, not make install_set_mac

What is missing?

scruzin commented 4 months ago

The Speaker makefile had some features that were useful for image creation. The SET_MAC and CONFIG flags gave us the ability to not perform device specific actions for image creation. I think after this big period of changing the installation process we should review the image creation process to streamline it. Perhaps it's just a guide of what files to copy where, but if we can automate parts of it we should.

Please let me know what speaker functionality is missing.

trekhopton commented 4 months ago

The Speaker makefile had some features that were useful for image creation. The SET_MAC and CONFIG flags gave us the ability to not perform device specific actions for image creation. I think after this big period of changing the installation process we should review the image creation process to streamline it. Perhaps it's just a guide of what files to copy where, but if we can automate parts of it we should.

It's easy enough to have optional make targets, and easier to maintain that multiple make files. For example, I added the optional SVC for the wifi service.

Anyway, I think we already have the functionality needed:

The set_conf_target is now obsolete, since it is handled by the package installer. And it is possible to not set the MAC by just calling make install, not make install_set_mac

What is missing?

This install requires that you provide a MAC address in MA and a device key therefore it's specific to a individual device.

That being said, I'm not sure we need the option to do a generic (non specific device) install for images. It should be fairly straight forward just copying some files over to the pi. Once we've created these new images we'll have a better idea of the work involved.

Not something to worry about with this PR I don't think.