search

ausocean / cloud

GNU General Public License v3.0
1 stars 1 forks source link

bench,tv: factor out BroadcastConfig into a package so both oceantv and oceanbench can use it #106

Open trekhopton opened 3 weeks ago

trekhopton commented 3 weeks ago

This should be done so we don't have to maintain two versions of the struct. Perhaps we should create a config.go in cmd/oceantv/broadcast package.

scruzin commented 3 weeks ago

This is covered by Issue #91, i.e., about the need for a common package.

In the case of the BroadcastConfig, while the struct is shared, there is very little common code. Oceanbench is responsible for populating,validating, and marshaling the struct, whereas Oceantv just unmarshals it and uses it.

I think there is a case to be made that this could live in ausocean/cloud/model, even though the BroadcastConfig is not at present a datastore entity.