search

ausocean / cloud

GNU General Public License v3.0
1 stars 1 forks source link

bench: use site timezone for broadcast, don't expect offset decimal #171

Closed trekhopton closed 3 days ago

trekhopton commented 4 days ago

This was done because the javascript was being used that interpreted the UTC offset string as a decimal, which caused the time to be off by an 30 minutes. This change should fix that. The site's timezone can be used to keep things consistent and avoid error from user input.

saxon-milton commented 4 days ago

In future, would recommend using a rebase on to master if you need to get up to date as opposed to a merge.

ao-david commented 4 days ago

Changes look good, but I wonder whether it even makes sense for the timezone to be changeable? Should we just use the site timezone and make it clear to the user that all times are based on the site timezone? I can't imagine many cases where a user would want to schedule a broadcast in a different location based on the timezone of their current location (mainly due to daylight hours etc...

At very least maybe this should also be an advanced feature that gets hidden behind the advanced checkbox?

scruzin commented 4 days ago

I think we should always use the site timezone. Otherwise we're simply asking for trouble.

On Thu, 27 June 2024, 8:59 am David (AusOcean), @.***> wrote:

Changes look good, but I wonder whether it even makes sense for the timezone to be changeable? Should we just use the site timezone and make it clear to the user that all times are based on the site timezone? I can't imagine many cases where a user would want to schedule a broadcast in a different location based on the timezone of their current location (mainly due to daylight hours etc...

At very least maybe this should also be an advanced feature that gets hidden behind the advanced checkbox?

— Reply to this email directly, view it on GitHub https://github.com/ausocean/cloud/pull/171#issuecomment-2192785171, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE3LX6GG2AC2MPBSLL23HDDZJNFGLAVCNFSM6AAAAABJ6AJPVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJSG44DKMJXGE . You are receiving this because your review was requested.Message ID: @.***>