ausocean / cloud

GNU General Public License v3.0
1 stars 1 forks source link

broadcast: OceanBroadcastManager.SaveBroadcast should use transaction #177

Closed saxon-milton closed 1 day ago

saxon-milton commented 2 days ago

Every other update of the broadcast config uses a transaction so that we can ensure things are synchronised properly, we should also do this with SaveBroadcast from the OceanBroadcastManager

scruzin commented 2 days ago

I think we should consider making the BroadcastConfig a database entity, so we have greater flexibility in how we update and access data. That said, the latter would be a big change with the potential to break things, so not a high priority.

saxon-milton commented 2 days ago

I think we should consider making the BroadcastConfig a database entity, so we have greater flexibility in how we update and access data. That said, the latter would be a big change with the potential to break things, so not a high priority.

I'm open to that, but I'm still not sure how much benefit that would bring at this stage. We only ever reference broadcasts by their name. Is there some other benefit I'm missing ?

scruzin commented 2 days ago

In future, we may wish to search for broadcasts by other properties, such as their YouTube account.

saxon-milton commented 2 days ago

In future, we may wish to search for broadcasts by other properties, such as their YouTube account.

True!