search

ausocean / cloud

GNU General Public License v3.0
1 stars 1 forks source link

Initial revision #19

Closed scruzin closed 1 month ago

scruzin commented 1 month ago

This is more or less a straight migration from https://bitbucket.org/AusOcean/vidgrind.

Mostly just headers have been updated.

Minor code changes:

saxon-milton commented 1 month ago

Seems OK. Personally with moves like this I think it's good to do a pure copy commit, and then another commit to update terminology etc. This way it's readily apparent what has changed.

trekhopton commented 1 month ago

Seems OK. Personally with moves like this I think it's good to do a pure copy commit, and then another commit to update terminology etc. This way it's readily apparent what has changed.

I agree, with the volume of lines, it's near impossible to see whats changed. A pure copy is something we can quickly approve then another PR to clearly see the changes eg. remove broadcast code and use cloud/notify.

scruzin commented 1 month ago

Seems OK. Personally with moves like this I think it's good to do a pure copy commit, and then another commit to update terminology etc. This way it's readily apparent what has changed.

I agree, with the volume of lines, it's near impossible to see whats changed. A pure copy is something we can quickly approve then another PR to clearly see the changes eg. remove broadcast code and use cloud/notify.

It's not too late. I'm happy to abandon this PR and do it in two separate PRs, the first being a pure copy of VidGrind.