search

ausocean / cloud

GNU General Public License v3.0
1 stars 1 forks source link

broadcast.go: the checkBroadcastsHandler should ensure disabled broadcasts are stopped #43

Open saxon-milton opened 4 months ago

saxon-milton commented 4 months ago

Currently in performChecksInternalThroughStateMachine if the broadcast is disabled, no checks are performed.

We have observed a case where broadcasts were started, then a new VidGrind version was pushed which disabled the broadcasts. Somehow the state machine and broadcasts were out of sync, the broadcasts were running but disabled. This shouldn’t happen and we should check to make sure that disabled broadcasts aren’t running.

In this case, all rigs ran their broadcasts overnight because they weren’t stopped.

trekhopton commented 1 month ago

I have increased the priority of this issue because it happens every time a broadcast is disabled ie. when it's disabled it doesn't stop. Our users are seeing the same behaviour. The workaround is to go to YouTube and end it via the UI but that is not a convenient action and users may not know that the livestream is still running. @ao-david I see you have assigned this to yourself, are you still working on it? I think I was mistaken when I thought Saxon attempted a fix, it seems like he just wrote this issue.

ao-david commented 1 month ago

Not currently working on this sorry

On Tue, 6 Aug 2024, 3:58 pm Trek H, @.***> wrote:

I have increased the priority of this issue because it happens every time a broadcast is disabled ie. when it's disabled it doesn't stop. Our users are seeing the same behaviour. The workaround is to go to YouTube and end it via the UI but that is not a convenient action and users may not know that the livestream is still running. @ao-david https://github.com/ao-david I see you have assigned this to yourself, are you still working on it? I think I was mistaken when I thought Saxon attempted a fix, it seems like he just wrote this issue.

— Reply to this email directly, view it on GitHub https://github.com/ausocean/cloud/issues/43#issuecomment-2270482615, or unsubscribe https://github.com/notifications/unsubscribe-auth/BGJ74NAWYQPX2JIYBSVO5SDZQBUINAVCNFSM6AAAAABH53SUS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZQGQ4DENRRGU . You are receiving this because you were mentioned.Message ID: @.***>