ausocean / cloud

GNU General Public License v3.0
1 stars 1 forks source link

Only email notify on consecutive bad health issues #94

Closed saxon-milton closed 4 weeks ago

saxon-milton commented 1 month ago

Depends on PR #92

Resolve issue #78

We used to email on any issue, even if it might have been just temporary. This is uneccessary and creates false concerns. So now we're only performing email notification on consecutive issues.

This has involved modifying how we check for issues i.e. we return the string of the issue rather than a bool. We also provide this to the badHealthCallback, where we can handle with health notification if we wish.

saxon-milton commented 4 weeks ago

It would be nice to be able to configure the number of consecutive bad health checks that constitute a serious enough problem to warrant an email notification. Otherwise, LGTM.

Yes fair. I'm going to create an issue for this.