auspicious3000 / SpeechSplit

Unsupervised Speech Decomposition Via Triple Information Bottleneck
http://arxiv.org/abs/2004.11284
MIT License
636 stars 92 forks source link

Question about padding #67

Closed summersunshine1 closed 2 years ago

summersunshine1 commented 2 years ago

I have a question about padding. It seems that the training of the model misses mask operation for padding.

auspicious3000 commented 2 years ago

Could you provide the line numbers?

summersunshine1 commented 2 years ago

In the model.py, it may be necessary for LSTM to do a mask for tokens with paddings. In the solve.py, it may be required for masking the loss of padded tokens.

auspicious3000 commented 2 years ago

Thanks for your suggestion. Please feel free to try it yourself and see how it works.