search

aussieaddons / plugin.video.abc_iview

ABC iView add-on for Kodi
http://aussieaddons.com/addons/abc_iview/
GNU General Public License v3.0
60 stars 24 forks source link

add 'inputstreamaddon' compatibility fix for kodi v19 #3087

Closed civillian closed 2 years ago

civillian commented 2 years ago

Fix for deprecated call to listitem.setProperty('inputstreamaddon', 'inputstream.adaptive') for kodi v19.

Running v2.0.6. I was unable to play content, with the following error logged:

ERROR <general>: CInputStreamAddon::Supports - 'inputstreamaddon' has been deprecated, please use `#KODIPROP:inputstream=inputstream.adaptive` instead

Reference: https://forum.kodi.tv/showthread.php?tid=353560

With aussieaddons repo enabled for dependencies.

NB: The link mentions also changing the manifest type, but I found it unnecessary to fix the issue, ie:

listitem.setProperty('inputstream.adaptive.manifest_type', 'hls') ...to... listitem.setProperty('inputstream.adaptive.manifest_type', 'mpd')

...was not required for me.

andybotting commented 2 years ago

Thanks @civillian

@glennguy Look ok to you?

glennguy commented 2 years ago

I don't think the error logged about deprecation has caused your issue - running fine on 19 here but all the same it's much nicer to only set the correct property rather than blindly do both as has been done here and other addons in this repo (my bad)

glennguy commented 2 years ago

Thanks @civillian!