aussierobots / ublox_dgnss

This usb based ROS2 driver is focused on UBLOX Generation 9 UBX messaging, for a DGNSS rover. High precision data is available.
Apache License 2.0
40 stars 22 forks source link

added printing serial_str_ & serial_num_string to error of not finding device with specificed serial string. #23

Closed iman01 closed 1 month ago

iman01 commented 6 months ago

Where feature was added? If DEVICE_SERIAL_STRING is set, and there are no devices with this serial string found, but there is a device found with different serial string, then error of "Error finding USB device with specified serial string" is triggered

What feature was added? The error message returns requested DEVICE_SERIAL_STRING and the serial string from device that was not matching.

Why? Makes it much easier to debug device's serial string as u-center might not correctly convert hex to string, inputting "base" can result in "esab".

Sample output before feature: [component_container_mt-1] [ERROR] [1711973415.228204225] [base.ublox_dgnss]: usb init error: Error finding USB device with specified serial string Sample output after feature: [component_container_mt-1] [ERROR] [1711973415.228204225] [base.ublox_dgnss]: usb init error: Error finding USB device with specified serial string, looking for "Test Base" however "esab" was found.

-Tested via connecting more than once device which one of them has the correct serial string, the error is not being triggered and connection is successful to one that is matching, the usb.cpp is already handling this.

Thanks :)

noob3-3 commented 6 months ago

I think it makes sense, and I also have this problem

hortovanyi commented 1 month ago

Hey guys sorry I thought I had merged this. There are some other changes and once they are done I will publish. Plus need to address Ubuntu 24.04 and Jazzy.