search

austenc / statamic-instagram-feed

Embed a public Instagram feed in your Statamic website with this addon
6 stars 0 forks source link

Instagram feed goes not past the limit of 12 #13

Open dryven-dano opened 3 years ago

dryven-dano commented 3 years ago

When the Instagram feed tag is used like this:

{{ instagram_feed profile="youtube" limit="27" }}

the parameter limit is read correctly (tested by a simple var_dump($this->params->get('limit')) in the tag class), but it is still only iterated a maximum of 12 times. A smaller number than 12 works flawlessly.

austenc commented 3 years ago

Hey @ddm-dano that's due to the way the results come back from instagram, they only come back 12 at a time right now. This package doesn't (currently) support any sort of pagination, but I might be open to merging a PR that added this.

Even better would be a way to allow users to access the underlying API instance in a callback (or several) so people could do all sorts of extra things.

This package is basically just a thin (and crappy) wrapper around this package: https://github.com/pgrimaud/instagram-user-feed#paginate

Anyway, as it stands right now (and sorry for the delay), I don't have much free time to dedicate to improving this package and don't expect to any time soon. That being said, I'm happy to entertain PRs to improve it, and would love some help from other devs in the community, thanks!