austgl / simplepo

Automatically exported from code.google.com/p/simplepo
0 stars 0 forks source link

Catalogue Not Found #3

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Add two translation catalogues to a database
2. Remove translation catalogue with the lower id
3. Go to the edit page for the remain catalogue.

What is the expected output? What do you see instead?

I would expect this to work without error messages instead an error message
pops up saying "Catalogue [2] Not Found".

What version of the product are you using? On what operating system?

rev 40 on RHEL 4

Please provide any additional information below.

I have fixed this error using the modification below. It allows catalogues
to be removed by removing the requirement for the catalogue id to be
related to the index of the array of catalogues returned. If the user
attempts to go to a non-existent catalogue the error message "No Messages
Found" still comes up.

$ svn di edit.html 
Index: edit.html
===================================================================
--- edit.html   (revision 40)
+++ edit.html   (working copy)
@@ -297,12 +297,10 @@
             $("<option />").attr('id',data[i]['id']).text(data[i]['name'])
                            .appendTo($('#catalogue_list'))
                            .attr('selected',data[i]['id'] == catId ?
'selected' : '');
+           if (data[i]['id'] == catId) {
+               $('#cat_name').text(data[i]['name']);
+           }
         }
-        if (catId > 0 && catId < data.length + 1){
-          $('#cat_name').text(data[catId-1]['name']);
-        } else {
-          NotificationObj.showError("Catalogue [" + catId + "] Not Found.");
-        }
       });
     };

Original issue reported on code.google.com by stephen....@gmail.com on 10 Nov 2009 at 5:10

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the patch.  Applied.

Original comment by JCampbe...@gmail.com on 20 Nov 2009 at 6:53