austin1244 / MI-449-SS17-740-html-more-kinds-of-content-OSB7Pe

0 stars 0 forks source link

Project Feedback #1

Open austin1244 opened 7 years ago

austin1244 commented 7 years ago

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

egillespie commented 7 years ago

Great theme, albeit a bit terrifying! :tennis: :fire: I think it's fantastic that you're using Bootstrap on these projects even though it's not a requirement, too!

When using tables, you typically want to use td elements for values, though. All of your cells currently use th. This makes all of the cells look the same, which is probably not desirable on a real feature comparison chart.

Could you update the $30/$60, 50/10, and Yes/No cells to be data cells instead of header cells?

When you've pushed your changes, comment here and I'll take another look.

Thanks!

austin1244 commented 7 years ago

@egillespie I changed the data cells to td

egillespie commented 7 years ago

Looks good. Thanks for taking the time to make these changes! :shipit: