Closed austinkahly closed 9 years ago
Looks mostly good. There aren't any integration tests but also there isn't really any logic that seems like it warrants one.
Also I'd like to see you use factory girl for your test data rails specific gem for your gemfile
# add this to test/test_helper.rb class ActiveSupport::TestCase include FactoryGirl::Syntax::Methods ....
create a test/factories.rb file and define your factories in it. use them in all your test files.
Looks mostly good. There aren't any integration tests but also there isn't really any logic that seems like it warrants one.
Also I'd like to see you use factory girl for your test data rails specific gem for your gemfile
create a test/factories.rb file and define your factories in it. use them in all your test files.