search

austinkelleher / giphy-api

🎥 Isomorphic JavaScript client for the Giphy.com API
MIT License
84 stars 19 forks source link

An in-range update of sinon is breaking the build 🚨 #27

Closed greenkeeper[bot] closed 7 years ago

greenkeeper[bot] commented 7 years ago

Version 2.3.5 of sinon just got published.

Branch Build failing 🚨
Dependency sinon
Current Version 2.3.4
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As sinon is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this :muscle:

Status Details - ❌ **continuous-integration/travis-ci/push** The Travis CI build could not complete due to an error [Details](https://travis-ci.org/austinkelleher/giphy-api/builds/244834087?utm_source=github_status&utm_medium=notification)
Release Notes Fix: Check configurable on a prop before creating
  • Check configurable on a prop before creating (fixes #1456) (#1462)
Commits

The new version differs by 8 commits.

  • 33f32ac Update docs/changelog.md and set new release id in docs/_config.yml
  • d00ab2b Add release documentation for v2.3.5
  • 1c690aa 2.3.5
  • cc0a3fb Update Changelog.txt and AUTHORS for new release
  • ef2ecec Check configurable on a prop before creating (fixes #1456) (#1462)
  • e7dbfd7 Merge pull request #1460 from gj/patch-1
  • 512018f Fix minor typos
  • d60d4a2 Fix apostrophe typos (#1454)

See the full diff

Not sure how things should work exactly? There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html) and of course you may always [ask my humans](https://github.com/greenkeeperio/greenkeeper/issues/new).

Your Greenkeeper Bot :palm_tree:

greenkeeper[bot] commented 7 years ago

After pinning to 2.3.4 your tests are still failing. The reported issue might not affect your project. These imprecisions are caused by inconsistent test results.

greenkeeper[bot] commented 7 years ago

Version 2.3.6 just got published.

Your tests are passing again with this version. Explicitly upgrade to this version 🚀

Commits

The new version differs by 30 commits.

  • 496f6b0 Update docs/changelog.md and set new release id in docs/_config.yml
  • 60a3284 Add release documentation for v2.3.6
  • 98119bf 2.3.6
  • 4f07053 Update Changelog.txt and AUTHORS for new release
  • 1fc4d59 Experiment over
  • 13e11c8 Experiment: Object.defineProperty(winodw, 'innerHeight'), Safari 10 - part 3
  • 76dd323 Experiment: Object.defineProperty(winodw, 'innerHeight'), Safari 10 - part 2
  • 83e84a9 Experiment: Object.defineProperty(winodw, 'innerHeight'), Safari 10
  • 6adba15 Merge pull request #1473 from fearphage/eslint-yaml
  • e1d188c fixed capitalization
  • d22eda3 Merge pull request #1313 from takasmiley/issues/#1274
  • 1661a0f Add test code of spy.matchingFakes
  • cf3a34e Move #1274 test code to respective test files
  • 833ff2c Replace for loop with Array.prototype.forEach
  • e72fee4 Update matchingFakes, always returns array

There are 30 commits in total.

See the full diff

greenkeeper[bot] commented 7 years ago

Version 2.3.7 just got published.

Your tests are passing again with this version. Explicitly upgrade to this version 🚀

Release Notes Fix #1476
  • Fix #1476: spy.withArgs(args...).firstCall is broken
Commits

The new version differs by 43 commits.

  • 9365d49 Update docs/changelog.md and set new release id in docs/_config.yml
  • 7399b99 Add release documentation for v2.3.7
  • 21b4588 2.3.7
  • 169ac9d Update Changelog.txt and AUTHORS for new release
  • 1108117 Merge pull request #1480 from fearphage/lint-staged
  • 9ecd56a moved from dependencies to dev dependencies [ci skip]
  • 0a85f21 improved linting for staged files [ci skip]
  • 079925b Merge pull request #1478 from takasmiley/issues/#1476
  • 40efa6f Cleanup a few test codes
  • 1ff2b9b Add spy.getCall tests with combination of withArgs arguments
  • c280916 Fix #1476: spy.withArgs(args...).firstCall is broken
  • 8ad2ed7 Merge pull request #1477 from mroderick/add-documentation-for-getcalls
  • fea23b0 Add missing documentation for spy.getCalls()
  • 496f6b0 Update docs/changelog.md and set new release id in docs/_config.yml
  • 60a3284 Add release documentation for v2.3.6

There are 43 commits in total.

See the full diff