always update tag - Githubissues

austinkregel / finance

A self hosted app to help you get a better understanding of your personal finances.

405 stars 47 forks source link

always update tag #43

Closed braceyourself closed 4 years ago

braceyourself commented 4 years ago

I noticed that the EditGroupModal 'Must all conditions be true?' checkbox wouldn't update on save.

use patch request
pass must_all_conditions_pass field with patch request

I also removed the condition where the original/updated name needed to be different in order to update. The original.name was always an object whereas the updated.name was the string name. Not much harm in just always updating as it's a manual function.

austinkregel commented 4 years ago

:fire: I love this 🙌 I've ran into this bug without even realizing it 😅 :bow: Thank you! I'll give this a more thorough review soon, but it looks good!

braceyourself commented 4 years ago

Sweet!

BTW - loving your work on this - very useful. Found it through the Laravel News podcast. Keep it up!