search

austinried / subtracks

A music streaming app for Subsonic-compatible servers
GNU General Public License v3.0
701 stars 30 forks source link

[Feature] ReplayGain support #21

Open CorePoint opened 2 years ago

CorePoint commented 2 years ago

Hey, would you consider adding ReplayGain support?

Your app looks really great so far btw.. Thanks for your work!

austinried commented 2 years ago

This one would be tough as I'm relying on react-native-track-player for audio playback, and it doesn't look like it supports it right now. If it's something that can be easily bolted on to ExoPlayer that might be possible as that's now being built as part of the project, but it would take some research.

CorePoint commented 2 years ago

Hey, thanks for your reply i did a little bit of research and it seems like none of the Music player that support replaygain use ExoPlayer. There was one issue opened in consideration to adding it to ExoPlayer, but it seems nothing came of it. I know the developer of Oto Music wants to switch to ExoPlayer in the future and I would be surprised if he would cut features for that, but it's not open source. But if he does the switch and it still supports replaygain maybe some questions can be asked. I will see what can be done when it's time (no ETA from him) and ping you.

Thanks for considering it, I get that it's a fringe feature to most.

Have a good day!

CorePoint commented 2 years ago

Good news, Auxio which also uses exoplayer implemented replaygain. Here is the issue in case you are interested in how it's solved in that app. https://github.com/OxygenCobalt/Auxio/issues/7

cn4750 commented 2 years ago

I second a feature request for basic ReplayGain support whenever it is made available. Just album/track support would be great.