search

austintackaberry / ydkjs-exercises

Exercises to go along with You Don't Know JavaScript
MIT License
253 stars 74 forks source link

Migrate from Material-UI to Styled Components #62

Closed austintackaberry closed 6 years ago

austintackaberry commented 6 years ago

I think we should move away from Material-UI, and @nikrb and @IrritatedEllipses were interested in using styled components, so that is what we will use.

Not sure if we want one person to work on this for the whole app or migrate page by page? Open to thoughts.

IrritatedEllipses commented 6 years ago

My current learning point is documentation so this question may stem from that:

Is the accepted protocol in situations like implementing aesthetic design to talk about what we'd like the app to look like and then design? Or to make a quick mock up and then share the idea? I'm sorry if this seems a pedantic question.

nikrb commented 6 years ago

@austintackaberry suggest you create each file as a task in your original post. I can help with the code. Perhaps @IrritatedEllipses is offering to do the design in the above comment?

nikrb commented 6 years ago

@IrritatedEllipses forgive me if it's too soon to ask, but wondering if you are willing to work on a design. The subject has come up in #59 .

IrritatedEllipses commented 6 years ago

@nikrb So sorry for taking so long to answer you. I've realized I'm a bit out of my element and I'm struggling to catch up on React. I'm really wanting to tackle this so I'm trying to catch up as much as I can. Judging from my progress so far I should be able to start contributing on 6/18/18

nikrb commented 6 years ago

@IrritatedEllipses no worries, thanx for responding and taking part. I would suggest the design per se doesn't really need react so it would be great if you could put some pics together with your ideas. If I've got the wrong end of the stick and you were wanting to do some coding that's kool ... but we still need someone to hash out a design/colour theme. @austintackaberry depending on 'ellipses' response, perhaps we should create a new issue requesting anyone with design skills to chip in?

austintackaberry commented 6 years ago

I have a feeling it might be difficult to get someone with design skills/interest. For this issue, it might make sense to just try to mimic the current design but use styled components (no need for it to be perfect)

nikrb commented 6 years ago

ok fair enough I'll make a start on it.

austintackaberry commented 6 years ago

https://github.com/austintackaberry/ydkjs-exercises/pull/81