search

austintackaberry / ydkjs-exercises

Exercises to go along with You Don't Know JavaScript
MIT License
253 stars 74 forks source link

Chapters that don't have any questions should not be clickable #82

Closed austintackaberry closed 6 years ago

austintackaberry commented 6 years ago

This issue is a result of #72. Originally, I was going to have just Up and Going Ch3 not be clickable, since it shouldn't have any questions given that it is just a preview of YDKJS. However, as I thought about it, I realized that any chapter that doesn't have any questions shouldn't be clickable. Open for discussion 🙂

nikrb commented 6 years ago

two penneth ... I prefer feedback when I click on something, nothing worse than not being sure if something is not working or just taking a while - a personal pet peeve.

austintackaberry commented 6 years ago

Yeah, that's a good point...But do you need to go to a whole different page? Maybe when you click, you get a small info popout?

austintackaberry commented 6 years ago

I'm also not sure what we should do with Up and Going Ch3

nikrb commented 6 years ago

no me either. I think it'll be odd not having any questions though if there's nothing to write questions on I can only think we manufacture some big picture questions loosely related to the other books.

austintackaberry commented 6 years ago

Maybe we should leave this open and get other opinions. I don't feel great about any option.

kevinsmithwebdev-zz commented 6 years ago

Does it even need to list chapters that don't have questions? Can't those be filtered out?

austintackaberry commented 6 years ago

There are many chapters that currently don't have questions but should have questions. We want there to be a "no questions" page to encourage users to contribute.

As for Up and Going Ch3, maybe it would be fine to just leave it off.