search

austinulmer / open-hardware-monitor

Automatically exported from code.google.com/p/open-hardware-monitor
0 stars 0 forks source link

ADL report VendorID for Nvidia is reported as 10 instead of 10DE #213

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
As summary.

ADL section below, UDID is correct though.

--------------------------------------------------------------------------------

AMD Display Library

Status: OK

Number of adapters: 4

AdapterIndex: 0
isActive: 1
AdapterName: ATI Radeon HD 4300/4500 Series       
UDID: PCI_VEN_1002&DEV_954F&SUBSYS_02A81043&REV_00_4&C98380&0&0030A
Present: 1
VendorID: 1002
BusNumber: 2
DeviceNumber: 0
FunctionNumber: 0
AdapterID: 0x94F18C0

AdapterIndex: 1
isActive: 0
AdapterName: ATI Radeon HD 4300/4500 Series       
UDID: PCI_VEN_1002&DEV_954F&SUBSYS_02A81043&REV_00_4&C98380&0&0030&02A
Present: 1
VendorID: 1002
BusNumber: 2
DeviceNumber: 0
FunctionNumber: 0
AdapterID: 0x94F18C0

AdapterIndex: 2
isActive: 1
AdapterName: NVIDIA GeForce 9600 GT
UDID: PCI_VEN_10DE&DEV_0622&SUBSYS_23651682&REV_A1_4&239521B6&0&0008A
Present: 1
VendorID: 10
BusNumber: 1
DeviceNumber: 0
FunctionNumber: 0
AdapterID: 0x94F18C0

AdapterIndex: 3
isActive: 0
AdapterName: NVIDIA GeForce 9600 GT
UDID: PCI_VEN_10DE&DEV_0622&SUBSYS_23651682&REV_A1_4&239521B6&0&0008&02A
Present: 1
VendorID: 10
BusNumber: 1
DeviceNumber: 0
FunctionNumber: 0
AdapterID: 0x94F18C0

--------------------------------------------------------------------------------

NVAPI

Version: NVidia Complete Version 1.10
Number of GPUs: 1

--------------------------------------------------------------------------------

Original issue reported on code.google.com by mtm78.cf...@gmail.com on 8 May 2011 at 9:33

GoogleCodeExporter commented 9 years ago 
This is an error in the ADL library which should be fixed by AMD. I think they 
just parse the first part of the UDID, that is all the numbers that follow 
"PCI_VEN_". The developer that implemented this probably didn't notice that the 
vendor ID is given in hex there. For ATI they return 1002 instead of 0x1002. 
And of course for Nvidia this results in 10 instead of 0x10DE. Funny enough 
things are different in their Linux implementation where they correctly return 
0x1002.

Not sure if it makes sense to take any action here in the Open Hardware Monitor 
(also it would not be too difficult to implement a workaround).

Original comment by moel.mich on 8 May 2011 at 10:26

GoogleCodeExporter commented 9 years ago 
The UDID is correct so it's ok, cosmetic flaw and I didn't know it was an 
underlaying api issue. The workaround is to parse the VendorID from the UDID 
myself, which I was already doing but still posted the issue since again I 
didn't know about the reason. Have to admit I didn't check in the source how 
you obtained the identifier, most likely I thought you were parsing it yourself 
from the UDID as well.

You can close the issue, though adding a workaround which detects if AMD has 
fixed their error but checking stringlength and if not apply the fix yourself. 
The report function benefits I think if all fields are accurate without having 
to resort to workarounds ( though it's a low priority issue even for me due to 
the workaround being so simple ).

I filed another request which is far more important to me :)

Original comment by mtm78.cf...@gmail.com on 8 May 2011 at 10:37

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r371.

Original comment by moel.mich on 15 Jan 2012 at 3:07