search

austocratic / acc-connector

Service records accounting transactions in Intacct
0 stars 0 forks source link

Remove hard coded sender ID and user ID #1

Closed jimmymcpeter closed 5 years ago

jimmymcpeter commented 5 years ago

@austocratic - Sage Intacct's monitoring tool threw an alert for this repository's code. I'm glad to see you have not hard coded any passwords. However, you have exposed your sender ID and user ID. You should really move these out to environment variables as well.

https://github.com/austocratic/acc-connector/blob/b7248fcff9371495c6b4b5a6d9f5427174f6d182/libraries/intacct.js#L14-L23

austocratic commented 5 years ago

Thanks for being proactive about this. I've moved sender & user IDs to env variables as you recommended.

I will close this issue