search

ausybenelux / Ocelot

Ocelot is a theming starter kit for drupal 7.
5 stars 2 forks source link

Convert variable (groups) to sass maps. #129

Closed sqndr closed 9 years ago

sqndr commented 9 years ago

_timings.scss contains global variables with a kinda strange name.

$superfast: 250ms;
$fast: 400ms;
$normal: 700ms;
$slow: 1000ms;

I would suggest we change this to $timings, a sass map.

$timings: ('superfast': 250ms, …);

Same goes for other variable groups, such as breakpoints, …

rob-bar commented 9 years ago

Misschien is het een goeie conventie om de var telkens de naam van de file te geven, in dit geval correct $timings <=> _timings.scss

rob-bar commented 9 years ago

Neem je ook nog de defaults en shades mee? Das iets meer werk.