search

ausybenelux / Ocelot

Ocelot is a theming starter kit for drupal 7.
5 stars 2 forks source link

Pull css minification away form the standard sass task #195

Closed rob-bar closed 8 years ago

rob-bar commented 8 years ago

The sass task now minifies the css .pipe(mincss()) but this should be bundled in the improve task and made separate.

It is more consistent, and it can be easier to inspect the plain css code to spot errors. If you do want the css to be expanded you can just run gulp compile (the grouped task without the improve this will expand the css).

There can also be a difference in output css on dev/stage and prod. Easier to debug and view the raw css files when bugs appear.

I know sourcemapping got us covered, but there are edge cases where you do want to look at the compiled css expanded. Debuggers like the ie9 debugger do not cover sourcemapping, I see an advantage there as well. Do not get me wrong, the standard gulp task will still minify the css, but it will be done in another separated step. Maybe we'll lose some milliseconds, but that is a minor issue since we win on flexibility.

rob-bar commented 8 years ago

I will close this one see... https://github.com/Crosscheck/Jacket/issues/6