Adding missing features entry to shpc

autamus / binoc

Binoc is a Lookout Bot that updates containers in Autamus

Apache License 2.0

5 stars 0 forks source link

Adding missing features entry to shpc #8

Closed vsoch closed 3 years ago

vsoch commented 3 years ago

Currently, recipes with features are truncated (the features are removed) because we do not represent them here! I am hoping this fixes it! Here is an example of the bug (that also shows the structure):

https://github.com/singularityhub/singularity-hpc/pull/419/files#diff-e430aec0977d84adbe1ce4c461262a4b50f5eb641578296e2e75cd7b152f56deL13

Signed-off-by: vsoch vsoch@users.noreply.github.com

vsoch commented 3 years ago

And for the key value pairs, the value can be a boolean OR null https://github.com/singularityhub/singularity-hpc/blob/66d7a723abd108669ffd599cbaa77f198a3c2fcc/shpc/main/schemas.py#L25. Does it look okay for that here (with bool and omitempty?)

alecbcs commented 3 years ago

Yeah I think this looks good to me!