search

autaut03 / kottle

Kotlin language provider for Forge 1.13.2+
GNU Lesser General Public License v3.0
31 stars 13 forks source link

Removed the jdk 6 version of the stdlib #15

Closed Naalunth closed 5 years ago

Naalunth commented 5 years ago

The org.jetbrains.kotlin:kotlin-stdlib is in conflict with the org.jetbrains.kotlin:kotlin-stdlib-jdk8 dependency. Having both is not a good idea.

Also updated the README.

Naalunth commented 5 years ago

Sorry for the inconvenience, should have checked the previous PR more thoroughly.

autaut03 commented 5 years ago

I don't think there's a need to bump the patch version, as 1.2.0 has never been released neither publicly or through git tags.

Otherwise - no problem. It's getting a little bit more popular, so maybe adding at least build CI would be a good idea to not break things anymore :)

Naalunth commented 5 years ago

Well it did build, your CI would need to actually build another Kotlin based mod using Kottle. That's rather involved. At least for me the error only showed when actually starting Minecraft.

autaut03 commented 5 years ago

Yea, like an integration test. Maybe even extract gradle config as a plugin and test it as well.

Not exactly an easy task for someone who doesn't work with Java a lot, but that's better than testing it manually, especially considering I'm planning to further support Kottle for future Forge versions.

autaut03 commented 5 years ago

Tested - works with my very basic test cases.

Published as beta. Thanks again.

TheLimePixel commented 5 years ago

This PR was definitely a mistake. You do need to have both. The JDK8 version just adds onto the the JDK6 one. The JDK6 one adds everything, from the primitives, to tuples, collections and most of the extensions.

TheLimePixel commented 5 years ago

For reference, this is everything that I'm now missing from the Standard Library: https://gist.github.com/EmosewaPixel/485bce0cf768abdec1e2524200602b4e