autaut03 / kottle

Kotlin language provider for Forge 1.13.2+
GNU Lesser General Public License v3.0
31 stars 13 forks source link

Added basic integration test #16

Closed Naalunth closed 5 years ago

Naalunth commented 5 years ago

I undid my last PR because it was plain wrong. Additionally I added a basic integration test for kottle.

You can run the test by running ./gradlew :integrationTest:runClient or ./gradlew :integrationTest:runServer. This will build kottle, build a mod using kottle, and then run a client or server and execute some Kotlin functions, just to make sure the libraries are actually present. The integration test mod will then automatically close Minecraft. Also, if you want to run a task on only kottle and not the integration test run it like ./gradlew :build (note the colon). The integration test is kinda hacky, but I don't know that much about Gradle, so that's the best I could come up with.

I set the version specifier to 1.2.0, I don't know if you have to change that after the faulty beta release.

I left quite the mess yesterday... sorry for that.

Naalunth commented 5 years ago

Note that the integration test mod automatically closing Minecraft actually crashes Gradle. I don't know why. Makes automation rather difficult sadly.

autaut03 commented 5 years ago

Hey again. Don't worry about it; it's good that you notified me of a problem. I definitely don't expect any contributor to know everything and test everything as noone would contribute then ;)

Thank you for yet another contribution, I do appreicate it!

I merged it onto a new branch and will try to make it work using some kind of CI tomorrow. For now, I'll post 1.2.1 with a fix (it's in master). Thank you!

autaut03 commented 4 years ago

Hey again! Just had my hands on that. It's now in master, every PR now has a build status (yay!).

Thank you again!