Remove unnecessary objects

autaut03 / kottle

Kotlin language provider for Forge 1.13.2+

GNU Lesser General Public License v3.0

30 stars 13 forks source link

Remove unnecessary objects #29

Closed TheLimePixel closed 4 years ago

TheLimePixel commented 4 years ago

This PR removes the unnecessary FMLKotlinModLoadingContext and KotlinAutomaticEventSubscriber objects and puts their methods in the file scope. As I now know, it's quite pointless and slightly inefficient using objects as namespaces in Kotlin. This additionally makes accessing the mod loading context much shorter.

This PR additionally replaces getModId() in string interpolation with the equivalent, but shorter modId, and fixes a slight inconsistency in the tests.

autaut03 commented 4 years ago

Hey there. It's been too much time and I'm unsure whether this is still relevant for you, but I'm letting you know that I'm merging this into a separate branch (from 2.x) and will revert some of the changes you've made (like removing objects), but otherwise keeping your commits.

Thanks.