search

autc04 / Retro68

a gcc-based cross-compiler for classic 68K and PPC Macintoshes
GNU General Public License v3.0
537 stars 51 forks source link

Completely revert expr.cc to gcc-12.2.0 upstream #246

Open agoode opened 2 months ago

agoode commented 2 months ago

When looking into #232 I reverted expr.cc back to the upstream gcc 12.2.0. This removed the HACK but also made another slight change regarding PUSH_ROUNDING.

Now that the hack is gone, you might want to consider this change as well. See https://github.com/gcc-mirror/gcc/blob/releases/gcc-12/gcc/expr.cc#L4430-L4435 for context.

autc04 commented 2 months ago

Good point. Still trying to figure this out some more.

It looks like the code in question is not being hit any more, but on the other hand, I do think it should take PUSH_ROUNDING into account if it is ever invoked.