Fixed orphaned change event listeners

auth0-blog / react-flux-jwt-authentication-sample

Sample for implementing Authentication with a React Flux app and JWTs

589 stars 102 forks source link

Fixed orphaned change event listeners #1

Closed stevecd closed 9 years ago

stevecd commented 9 years ago

As implemented, it seems like EventEmitter.removeListener wasn't matching any listeners. This had react warning about calling setState on unmounted components if users would login/out multiple times.

Added a new instance variable, changeListener to components to store reference to change callbacks.
Used this reference in removeListener.

mgonto commented 9 years ago

I saw the warnings but didn't know what they were.

Thanks for the PR :). Now it looks awesome.

Merging!