auth0-blog / redux-auth

MIT License
384 stars 69 forks source link

Show use of Auth0-lock #2

Closed neverfox closed 8 years ago

neverfox commented 8 years ago

It seems that all of Auth0's examples with Flux or Redux resort to assuming a custom JWT provider, which I find bizarre given that they have their Lock product. Why is that? It would be really great if these examples showed how Lock could work with Redux. In my attempts, they seem to be at odds (since Lock works with a roundabout callbackURL), but surely something is possible.

chenkie commented 8 years ago

For these examples and tutorials we like to show a general use case without assuming any particular JWT implementation :)

Have you looked at the aside in this post? It shows an implementation with Lock.

neverfox commented 8 years ago

I just found that article right after I posted this, however the Lock discussion still feels incomplete and, in some aspects, incorrect (for example, it shows calling the login action with creds, and doesn't make use of the SHOW_LOCK action at all). I am going to try it out though and see what questions arise.

neverfox commented 8 years ago

I will add though, that while I understand the value of general examples, the lack of Lock examples in the same context feels strange. Lock creates unique challenges that it would be nice to see solved to a basic degree, even if it means creating another working example alongside this one.

chenkie commented 8 years ago

Thanks for the feedback :) We can look at doing a full example with Lock. Which unique challenges are you thinking of?

klatchbaldar commented 8 years ago

In the blog post, with regards to adding Lock, you say, "With these actions in place, we can now add them to our reducer to handle authentication state change just like we would with any other action." However you don't have a code block that shows how to add them to the reducer. Are you able to create a branch that has Auth0-specific code?

chenkie commented 8 years ago

Hey @klatchbaldar, I'll look at adding this. Still need to get a full example with Lock going which is on my todo list :)

bryannaegele commented 8 years ago

@chenkie If you can create a Lock branch I can put in a PR. I had to do this for a project today and modified the example for a POC.

chenkie commented 8 years ago

Awesome, thanks @bryannaegele! https://github.com/auth0/redux-auth/tree/auth0-lock

bryannaegele commented 8 years ago

@chenkie I forgot to add the snippets for updating the server. This should get somebody to a fully working example.

chenkie commented 8 years ago

beauty, thanks @bryannaegele :+1:

camsjams commented 7 years ago

Thanks @chenkie / @bryannaegele for the Lock version! 🥇 💯