auth0-extensions / auth0-account-link-extension

An extension aimed to help link accounts easily
MIT License
28 stars 76 forks source link

Update put_settings.js to allow longer tld's to be used #122

Open Fastbuilder575 opened 2 years ago

Fastbuilder575 commented 2 years ago

✏️ Changes

Description:

-> The current longest tld is 24 characters as of (https://data.iana.org/TLD/tlds-alpha-by-domain.txt) so the max length should be increased from 6 to 24 to allow all domains to be used

What did you change in the code itself?

-> Increased a value in the RegEx to allow longer tlds to be used.

🔗 References

List of official TLD's that should be supported: https://data.iana.org/TLD/tlds-alpha-by-domain.txt

🎯 Testing

Describe how this can be tested by reviewers. Please be specific about anything not tested and reasons why.

Try the RegEx with a domain that has a longer tld than 6 characters

🚀 Deployment

Can this change be merged at any time? What will the deployment of the change look like? Does this need to be released in lockstep with something else?

✅ This can be deployed any time

🖥 Appliance

Note to reviewers: ensure that this change is compatible with the Appliance.

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?