search

auth0-samples / auth0-react-sample

130 stars 149 forks source link

adding 05-linking-accounts with LinkAccountService and LinkedAccounts… #8

Closed flaviogranero closed 8 years ago

flaviogranero commented 8 years ago

…List/ListAccountItem components

alemata commented 8 years ago

👍 @ntotten @chenkie

flaviogranero commented 8 years ago

@mpaktiti this is ready

chenkie commented 8 years ago

Thanks. There are a couple issues to fix :)

chenkie commented 8 years ago

We also need a more explicit check when mapping over the identities to account for error cases. For example, this is what I got back:

identities = {
  error: "Bad Request",
  errorCode: "operation_not_supported",
  message: "Main identity and the new one are the same.",
  statusCode: 400
}

http://d.pr/i/OBsn

flaviogranero commented 8 years ago

hi @chenkie you're right about missing bootstrap, I'll be fixing in all PRs. About the warnings you see in the console, it's an issue in react-bootstrap library https://github.com/react-bootstrap/react-bootstrap/issues/1994 with React 15.2.0 seems like it's already fixed, but not released. We have the option to fix a previous version of React js in our package.json, or wait for a new react-bootstrap release. what do you think?

flaviogranero commented 8 years ago

@chenkie the other reported issues are fixed, let me know what do you prefer for react-bootstrap warnings

chenkie commented 8 years ago

Awesome, looks good @flaviogranero thanks.

We'll leave the React deps as they are. Sounds like a new react-bootstrap release will be happening very quickly.

Thanks