CI build error due to recent Package.swift update

tatsuki-nakano-simplisafe commented 1 year ago

Checklist

[X] I have looked into the Readme, Examples, and FAQ and have not found a suitable solution or answer.
[X] I have looked into the API documentation and have not found a suitable solution or answer.
[X] I have searched the issues and have not found a suitable solution or answer.
[X] I have searched the Auth0 Community forums and have not found a suitable solution or answer.
[X] I agree to the terms within the Auth0 Code of Conduct.

Describe the problem you'd like to have solved

Hi, our CI tool started to report these error. It seems these dependencies and Auth0 have been updated Package.swift to drop iOS12 support. But Auth0 has not been bumped version so SimpleKeychain and JWTDecode fetches latest codes but Auth0 isn't.

❌ error: The package product 'SimpleKeychain' requires minimum platform version 13.0 for the iOS platform, but this target supports 12.0 (in target 'Auth0' from project 'Auth0') ❌ error: The package product 'JWTDecode' requires minimum platform version 13.0 for the iOS platform, but this target supports 12.0 (in target 'Auth0' from project 'Auth0')

Describe the ideal solution

bump Auth0 version so that SPM aware of latest changes

Alternatives and current workarounds

No response

Additional context

No response

rod-schmidt-cricut commented 1 year ago

We're having the same issue.

MKE-RobertHaworth commented 1 year ago

This issue is being caused by SimpleKeychain and JWTDecode introducing a minimum deployment mismatch. Due to Auth0 not targeting a specific version of these dependencies or being safeguarded by major version revision changing in the dependencies listed above.

A temporary work around for this is to target explicitly JWTDecode version 3.0.1 and SimpleKeychain version 1.0.1.

If you are targeting Auth0 in a dependency library, you will need to explicitly target these versions of the sub-dependencies in both your primary target and any dependencies chaining these changes in.

I would recommend Auth0 begin targeting explicit versions of the dependencies to guard against breaking change updates like this.

tatsuki-nakano-simplisafe commented 1 year ago

as temporary work around, you can specify Auth0 with commit ID: b8e2bf597c9b1d745de2b575e2931dab62321ab9 on SPM

tomhopkins commented 1 year ago

Would the work around be effective in Expo? I'm not sure where it would be implemented.

Thanks in advance.

Widcket commented 1 year ago

Hi all, thanks for raising this.

We're aligning all our Swift libraries to support iOS 13+. We expect to release a new version of Auth0.swift today.

As mentioned in our Support Policy, dropping unsupported platform versions is not considered a breaking change.

tomhopkins commented 1 year ago

Thanks. And fair enough. Apologies: I spent 3 hours trying to work out what I’d done wrong!

bjarnel commented 1 year ago

Same, you broke your own framework Auth0!

Widcket commented 1 year ago

Auth0.swift v2.4.0 is out now!

My apologies for the delay in releasing Auth0.swift respective to JWTDecode.swift and SimpleKeychain, and the CI failures that ensued.

tomhopkins commented 1 year ago

Could someone have a look at my follow up. I still can’t build any expo projects with auth0 in them. They work when I take it out.

Tom Hopkins 0776 22 555 30

From: Rita Zerrizuela @.> Sent: Thursday, June 15, 2023 12:39:58 PM To: auth0/Auth0.swift @.> Cc: Tom Hopkins @.>; Comment @.> Subject: Re: [auth0/Auth0.swift] CI build error due to recent Package.swift update (Issue #776)

Closed #776https://github.com/auth0/Auth0.swift/issues/776 as completed.

— Reply to this email directly, view it on GitHubhttps://github.com/auth0/Auth0.swift/issues/776#event-9539309825, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABJ5V5GDEQJ2N6YTZQ4L65DXLLYA5ANCNFSM6AAAAAAZGZKUVE. You are receiving this because you commented.Message ID: @.***>

MKE-RobertHaworth commented 1 year ago

Could someone have a look at my follow up. I still can’t build any expo projects with auth0 in them. They work when I take it out. Tom Hopkins 0776 22 555 30 …

You need to be targeting latest release (2.4.0) and this issue will be resolved. This is working for me as of this morning.

tomhopkins commented 1 year ago

Thanks for the reply. Have you seen it working with expo/eas?

Widcket commented 1 year ago

@tomhopkins are you using Auth0.swift through the react-native-auth0 SDK? If so, please update to v2.17.4. It should be fixed.

tomhopkins commented 1 year ago

Thanks. I see there's a new release about an hour ago and that has fixed it. Thank you very much.

auth0 / Auth0.swift