Replacing NSCoder with Swift's Codable

Vaidios commented 1 month ago

[x] All new/changed/fixed functionality is covered by tests (or N/A)
[x] I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Replaced occurrences of NSKeyedUnarchiver/NSKeyedArchiver with JSONDecoder/JSONEncoder
Added encode function to Credentials type

📎 References

It doesn't seem like usage of this API is required in this context. Credentials type doesn't use polymorphism, which could be only handled by NSKeyedUnarchiver.

Thanks to these changes my code now properly runs inside a SPM package

Please let me know if there is something that I don't understand :)

https://forums.swift.org/t/should-i-stick-with-codable-or-switch-back-to-nscoding/61604 https://github.com/auth0/Auth0.swift/issues/862

🎯 Testing

This is not a breaking change, these code paths are covered by unit tests

Vaidios commented 1 month ago

@theolampert sorry for tagging you here, I was just wondering if there is any button to ask for the review from maintainers and I clicked it without thinking much about it :E

desusai7 commented 1 month ago

Hi @Vaidios,

Thank you for raising a PR to address this, we will look into it and get back to you !

Vaidios commented 3 weeks ago

Hey @desusai7, are there any updates on this?

auth0 / Auth0.swift