feat: added support for webview as a provider for webauth

auth0 / Auth0.swift

Auth0 SDK for Apple platforms

https://auth0.github.io/Auth0.swift

MIT License

345 stars 225 forks source link

feat: added support for webview as a provider for webauth #875

Closed desusai7 closed 2 days ago

desusai7 commented 2 weeks ago

📋 feat: added support for webview as a provider for webauth

Added WKWebView as a User Agent for WebAuthentication along with ASWebAuthenticationSession & SFSafariViewController

Checklist

[x] All new/changed/fixed functionality is covered by tests (or N/A)
[] I have added documentation for all new/changed functionality (or N/A)

🎯 Testing

Ensure that the WKWebView is working as a User Agent for performing the WebAuthentication

fal3 commented 2 weeks ago

I've tested this on my local branch and it still does not fix my webview issue.

desusai7 commented 1 week ago

I've tested this on my local branch and it still does not fix my webview issue.

Hi @fal3,

Can you please share more details about the webview issue you are running into ?

fal3 commented 1 week ago

I've tested this on my local branch and it still does not fix my webview issue.

Hi @fal3,

Can you please share more details about the webview issue you are running into ?

We get this simulator crash 👇 . Which is also related to this incident

log.txt

desusai7 commented 1 week ago

I've tested this on my local branch and it still does not fix my webview issue.

Hi @fal3, Can you please share more details about the webview issue you are running into ?

We get this simulator crash 👇 . Which is also related to this incident

log.txt

@fal3, I would like to clarify that this pull request is not intended to address the issue you mentioned. Additionally, regarding the crash you are experiencing, could you please confirm if you were able to reproduce this issue on a real device as well?

furrki commented 1 week ago

I've tested this on my local branch and it still does not fix my webview issue.

Hi @fal3, Can you please share more details about the webview issue you are running into ?

We get this simulator crash 👇 . Which is also related to this incident log.txt

@fal3, I would like to clarify that this pull request is not intended to address the issue you mentioned. Additionally, regarding the crash you are experiencing, could you please confirm if you were able to reproduce this issue on a real device as well?

I can confirm that this issue happens only on simulator.