auth0 / SimpleKeychain

A simple Keychain wrapper for iOS, macOS, tvOS, and watchOS
https://auth0.github.io/SimpleKeychain
MIT License
587 stars 76 forks source link

Xcode 12 Compilation Warning Fix #96

Closed paulryanclark closed 4 years ago

paulryanclark commented 4 years ago

Changes

Please describe both what is changing and why this is important. Include:

References

Please include relevant links supporting this change such as a:

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If helpful, please include manual testing steps as well.

[ ] This change adds unit test coverage (or why not)

[ ] This change has been tested on the latest version of the platform/language or why not

Checklist

[ ] I have read the Auth0 general contribution guidelines

[ ] I have read the Auth0 Code of Conduct

[ ] All existing and new tests complete without errors

Widcket commented 4 years ago

Hi @paulryanclark, the library builds fine with Xcode 12 on Catalina. Are you using BigSur?

Screen Shot 2020-10-06 at 11 16 40
Widcket commented 4 years ago

I just tested compiling the library with Xcode 12 on the latest beta of Big Sur, and I wasn't able to reproduce the issue. If you have any further information, please ping.

paulryanclark commented 4 years ago

@Widcket Sorry for the confusion. This MR fixes a triggered warning on Xcode 12. You can see in the attached screenshot that there is still a build warning.

We treat all warnings within our imported Pods as build errors, so merging this change will allow us to use this repo, instead of having to use a fork with a fix for the warning.