Closed dschenkelman closed 10 years ago
The rest looks good :)
Two things: 1) Please update the documentation (Details.md, GettingStarted.md) 2) Currently our samples are showing only how to call the methods separately. Maybe, we need samples showing common scenarios (login -> save refresh_token -> validate it -> exchange it for id_token -> call an api, etc.)
1) Please update the documentation (Details.md, GettingStarted.md) 2) Currently our samples are showing only how to call the methods separately. Maybe, we need samples showing common scenarios (login -> save refresh_token -> validate it -> exchange it for id_token -> call an api, etc.)
+1 to both.
+20. I agree that samples on this scenario would be great! It's something I know we had to just pull out of thin air. Lot's of trial and error.
I will be most llikely using the iOS samples in this to test this scenario tonight with code I already kind of have working for refreshing and storing tokens with Keychain. If interested, I can send what I got once I have stuff working.
Created #7 for the samples. Will update docs as part of this PR.
@mgonto mind reviewing? still need to update the implementation to get the dev id/name in Android.
@tvand7093: this is the updated PR.