search

auth0 / angular-jwt

Library to help you work with JWTs on AngularJS
MIT License
0 stars 1 forks source link

UI Router 1.0.0 Fix #161

Closed jasonmgeorge closed 5 years ago

jasonmgeorge commented 7 years ago

I am noticing that unauthenticatedRedirectPath no longer seems to trigger with the ui router transition code. If I force legacy state events unauthenticated redirect works with unauthenticatedRedirectPath and authManager.redirectWhenUnauthenticated(). https://ui-router.github.io/ng1/docs/latest/modules/ng1_state_events.html

Stepping through, it looks like the unauthenticated redirect is relying on loginPath and loginPath requires app state as opposed to a path.

chenkie commented 7 years ago

The library needs to be updated to support UI Router 1.0. It's in the backlog but no ETA yet unfortunately.

4O4 commented 7 years ago

Hi @chenkie Actually I submitted pull request for this some time ago (#155 ) I've been succesfully using my fork in production since then with angular-ui-router version ^1.0.3. It would be nice if you could merge / review my PR :)

d3l33t commented 6 years ago

please fix

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️