auth0 / angular-jwt

Library to help you work with JWTs on AngularJS
MIT License
0 stars 1 forks source link

urlBase64Decode issue #168

Closed aresot closed 4 years ago

aresot commented 6 years ago

Hi. We stumbled upon case when urlBase64Decode fails decoding valid token. when Im looking inside that function I see you using return decodeURIComponent(escape(window.atob(r))). According to cods "escape" is deprecated and you should use encodeURIComponent instead. When I replaced escape with encodeURIComponent our problematic token was decoded correctly.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️

timelf123 commented 4 years ago

This is still an issue

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️