auth0 / angular-jwt

Library to help you work with JWTs on AngularJS
MIT License
0 stars 1 forks source link

Breaking changes in latest patch release 0.1.10 #177

Closed brad-sobie closed 4 years ago

brad-sobie commented 6 years ago

The latest release (0.1.10) broke my application. I'm thinking it's related to this year old commit, which was just pulled in. It looks like this commit changed the routing hooks that are used if you're using the newest version of ui router (which I am). Basically I used to be able to do this, but now I can't:

$urlRouterProvider.when('/', ($rootScope) => {
    // $rootScope.isAuthenticated used to be set at this point in time
    // but now it's always false even with a valid token
    if ($rootScope.isAuthenticated) {

    } else {

    }
});

Working with 0.1.9 https://jsfiddle.net/kjc90sm6/10/

Broken with 0.1.10 https://jsfiddle.net/udfcb7mz/2/

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you have not received a response for our team (apologies for the delay) and this is still a blocker, please reply with additional information or just a ping. Thank you for your contribution! 🙇‍♂️