search

auth0 / angular-jwt

Library to help you work with JWTs on AngularJS
MIT License
0 stars 1 forks source link

Interceptor can choke on undefined response #184

Closed sithwarrior closed 5 years ago

sithwarrior commented 5 years ago

If you loose you internet connection, while a request is pending, the resulting response in the intercepter will be undefined, forcing an error on the status check.

I've created a small fix and submitted a pull request #183

The issue can be reproduced by creating a network condition in google dev tools, with a long response time, starting a new token request, and switching to offline.

screenshot 2019-01-04 at 14 43 15

sithwarrior commented 5 years ago

Any update on getting this merged?

sithwarrior commented 5 years ago

@luisrudge great that this got merged. Can we get it into a release, so its gets on NPM etc?

luisrudge commented 5 years ago

released on angular-jwt@0.1.11

sithwarrior commented 5 years ago

Sorry to keep bothering @luisrudge But could you update the release tags here on github, as thats how Bower resolves versions. Right now bower install angular-jwt resolves 0.1.10 as thats the newest release version on github.

luisrudge commented 5 years ago

@sithwarrior no problem at all. Sorry to make you wait on this. This is an old package and the release process is not automated 😬 I just created the release on github!