search

auth0 / angular-lock

MIT License
18 stars 15 forks source link

using explicit annotation, so it would work with ng-strict-di #2

Closed hao1939 closed 8 years ago

hao1939 commented 8 years ago

Hi @chenkie,

Angular-lock would break the application if angular is running with strict-di mode enabled. The problem occurred using the normal '.js', the '.min.js' has dealt it correctly.

Thanks, Hao Yuan

chenkie commented 8 years ago

The non-minified version in the dist folder has the annotation :) It's added in the build step, which means we don't need to keep it in the src and thus we can keep it a bit cleaner.

hao1939 commented 8 years ago

Well, if you are using bower, you will encounter problem. The bower would include the source file which package.json pointed to, bad lucky, it was pointed to the source file, not the one in folder dist/.

chenkie commented 8 years ago

Gotcha. We can update the package.json and bower.json files to point to dist/angular-lock.js then. Do you want to modify your PR to do that?

hao1939 commented 8 years ago

Don't you think this PR is more straighforward? If we use explicit annotation everywhere, there woule be no way any body encountered this error again, or any misleading.

chuckmah commented 8 years ago

agree this would be useful.. I had the same problem,

i'm using angular 1.5 with webpack