auth0 / auth0-PHP

PHP SDK for Auth0 Authentication and Management APIs.
https://auth0.com/docs/libraries/auth0-php
MIT License
380 stars 209 forks source link

fix: Remove redundant token verification step #742

Closed evansims closed 9 months ago

evansims commented 9 months ago

Changes

This PR removes a redundant JWT verification step identified in #741. Verification is already performed in the token verifier constructor, so calling its verify() method afterward is redundant and unnecessary.

References

Closes #741.

Testing

No changes to testing were necessary for this change.

Contributor Checklist

codecov-commenter commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a8efbb8) 100.00% compared to head (9197f84) 100.00%. Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #742 +/- ## =========================================== Coverage 100.00% 100.00% - Complexity 1338 1339 +1 =========================================== Files 62 62 Lines 4670 4671 +1 =========================================== + Hits 4670 4671 +1 ``` | [Flag](https://app.codecov.io/gh/auth0/auth0-PHP/pull/742/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | Coverage Δ | | |---|---|---| | [unittestsvalidate](https://app.codecov.io/gh/auth0/auth0-PHP/pull/742/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0) | `100.00% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=auth0#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

evansims commented 9 months ago

Making some minor unrelated code tweaks to accommodate upstream changes to our CI tooling, so tests will pass.

evansims commented 9 months ago

Please disregard the remaining failing Rector and PHP CS Fixer tests, I need to fix a bug in the CI workflow there. The tests pass fine locally.