auth0 / auth0-angular

Auth0 SDK for Angular Single Page Applications
MIT License
174 stars 57 forks source link

Add Angular 17 support #586

Closed mbrammer closed 4 months ago

mbrammer commented 4 months ago

Checklist

Describe the problem you'd like to have solved

Just tried to update to Angular 17 and got this errors:

Package "@auth0/auth0-angular" has an incompatible peer dependency to "@angular/common" (requires ">=12 <=15" (extended), would install "17.2.3").
Package "@auth0/auth0-angular" has an incompatible peer dependency to "@angular/core" (requires ">=12 <=15" (extended), would install "17.2.3").
Package "@auth0/auth0-angular" has an incompatible peer dependency to "@angular/router" (requires ">=12 <=15" (extended), would install "17.2.3").

I'm actually running on Angular 16.2.12 already, so this is somehow strange because the messages says requires ">=12 <=15".

Also is there a doc which indicates which Angular versions are supported? I only found a hint in the release notes that mentioned Angular 15 support within v1.11.1

Describe the ideal solution

@auth0/auth0-angular should support latest Angular version.

Alternatives and current workarounds

No response

Additional context

No response

frederikprijck commented 4 months ago

You want to move to v2 of our SDK, which supports Angular 17.

v1 only supports up until 15.

We have a migration guide on how to move to v2, but I am happy to help wherever needed if you have any difficulties.

The general rule is, our latest version supports all current versions supported by Angular, see https://github.com/auth0/auth0-angular?tab=readme-ov-file#requirements

When not using the latest version, compatibility depends on the time that version was released.

mbrammer commented 4 months ago

I am using "@auth0/auth0-angular": "^2.2.3", and getting this error...

frederikprijck commented 4 months ago

That's not something that should be happening.

As you can see here, v2.2.3 has a peerDependency of:

  "peerDependencies": {
    "@angular/common": ">=13",
    "@angular/core": ">=13",
    "@angular/router": ">=13"
  },

While your error talks about requires ">=12 <=15", which happens to be our peerDependencies configuration on v1, see: https://www.npmjs.com/package/@auth0/auth0-angular/v/1.11.1?activeTab=code

What's the output of npx npm-why @auth0/auth0-angular on your project?