Closed willvedd closed 9 months ago
Attention: 3 lines
in your changes are missing coverage. Please review.
Comparison is base (
93f54e2
) 71.95% compared to head (6f6ded4
) 72.05%.
Files | Patch % | Lines |
---|---|---|
internal/cli/logs.go | 90.90% | 2 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
🔧 Changes
As noted by #936 , the
auth0 logs list
command's--number
flag does not have an effect for any value above 100. This PR introduces a pagination mechanism such that the correct number of logs are requested.📚 References
Related issue: #936
🔬 Testing
Added integration test cases .
However, the test tenant won't reliably have a high number of logs, which makes testing the pagination functionality tricky. For these cases, I tested locally against my tenant with
--number
equaling 1,499,500,501 and 1000.📝 Checklist