Bugfix/issue 875 - Githubissues

auth0 / auth0-deploy-cli

The Auth0 Deploy CLI is a tool that helps you manage your Auth0 tenant configuration. It integrates into your development workflows as a standalone CLI or as a node module.

MIT License

236 stars 147 forks source link

Bugfix/issue 875 #876

Closed BavoLuysterborg closed 6 months ago

BavoLuysterborg commented 6 months ago

🔧 Changes

Added sink.azurePartnerTopic as a field to be stripped when creating a log stream
Fixes #875

📚 References

Create a log stream - Auth0 Management API v2

🔬 Testing

Covered by unit test

Manual testing:

Import log stream of the format

logStreams:
- name: Azure Event Grid
filters:
- type: category
name: auth.token_exchange.fail
- ...
sink:
azureSubscriptionId: <subscription id>
azureRegion: <region>
azureResourceGroup: <resource group>
azurePartnerTopic: <partner topic name>
status: active
type: eventgrid

Create operation should succeed

📝 Checklist

[x] All new/changed/fixed functionality is covered by tests (or N/A)
[x] I have added documentation for all new/changed functionality (or N/A)

willvedd commented 6 months ago

Thanks for opening this PR. This is exactly what should be done here. I'll be able to take a closer look today but hopefully can merge soon.

willvedd commented 6 months ago

I can confirm that the E2E are running and passing locally so going to merge.