The branding location changes is a breaking change

edjanmichiles-toast commented 3 months ago

Checklist

[X] I have looked into the README and have not found a suitable solution or answer.
[X] I have looked into the documentation and have not found a suitable solution or answer.
[X] I have searched the issues and have not found a suitable solution or answer.
[X] I have upgraded to the latest version of this tool and the issue still persists.
[X] I have searched the Auth0 Community forums and have not found a suitable solution or answer.
[X] I agree to the terms within the Auth0 Code of Conduct.

Description

The recent changes to the branding template path have caused a bug in the deploy pipeline: https://github.com/auth0/auth0-deploy-cli/commit/4b24d78a49c5add2b21f8a910c26448d8a1d0337:

2024-08-09T11:42:34.633Z - error: Problem running command import
2024-08-09T11:42:34.634Z - error: Problem deploying branding, Error: Unable to load file /actions-runner/_work/config-customer-authentication/config-customer-authentication/branding_templates/universal_login.html due to Error: ENOENT: no such file or directory, access '/actions-runner/_work/config-customer-authentication/config-customer-authentication/branding_templates/universal_login.html'

Expectation

The deploy to work as expected

Reproduction

Just run the deploy to auth0 using the CLI

Deploy CLI version

7.24.1

Node version

20.x

gerardino-smg commented 3 months ago

I would like to say this is not a bug but more of a breaking change. In this PR the code that loads the branding template completely ignores the templateDefinition.body and instead expects a file named ${templateDefinition.template}.html.

I'm currently using liquid templates and this pretty much breaks the use for them.

gerardino-smg commented 3 months ago

Created this PR: https://github.com/auth0/auth0-deploy-cli/pull/942

edjanmichiles-toast commented 3 months ago

I would like to say this is not a bug but more of a breaking change.

I've updated the issue name to reflect it, you're right

stephenmelrose commented 3 months ago

We've just come across this. Worth reverting the original change and getting a new version out?

kushalshit27 commented 2 months ago

A fix for this has been provided in 7.24.2. Please update and advise if you have any further issue. I would appreciate you test this out and if problem still persists, we can re-evaluate. However I'm going to close in the meantime. Thanks for opening this ticket!

auth0 / auth0-deploy-cli