Closed kushalshit27 closed 2 months ago
Attention: Patch coverage is 87.50000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 84.32%. Comparing base (
4b062cf
) to head (1a66515
).
Files | Patch % | Lines |
---|---|---|
src/utils.ts | 80.00% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Quick question, our pipeline is failing with this error
2024-08-14T15:13:07.881Z - error: Problem running command import 2024-08-14T15:13:07.881Z - error: Problem deploying branding, Error: Unable to load file /universal_login.html due to Error: ENOENT: no such file or directory, access '/branding_templates/universal_login.html
Does this pr solve this issue.
Hi, @vasantteja This should solve the error:
I have tested for tenant.yaml: POSIX path on yaml:
- template: universal_login
body: ./branding_templates/universal_login.html
Windows path on yaml:
- template: universal_login
body: .\branding_templates\universal_login.html
Same test has been done for json(directory)
export/import.
Hi, @vasantteja This should solve the error:
I have tested for tenant.yaml: POSIX path on yaml:
- template: universal_login body: ./branding_templates/universal_login.html
Windows path on yaml:
- template: universal_login body: .\branding_templates\universal_login.html
Same test has been done for
json(directory)
export/import.
Thanks for the update. Appreciate the help.
Hi @kushalshit27,
I noticed that another PR related to this issue was merged in version 7.24.1. I used it to run our pipeline, but it failed with the same error mentioned above. I assume our issue will not be resolved until this PR is merged. Do you have any idea when this PR will be merged?
@vasantteja planning to release today!
🔧 Changes
📚 References
🔬 Testing
Testing has been done considering different path for POSIX and Windows. For tenant.yaml: POSIX path on yaml:
Windows path on yaml:
Same test has been done for
json(directory)
export/import.📝 Checklist