search

auth0 / auth0-deploy-cli

The Auth0 Deploy CLI is a tool that helps you manage your Auth0 tenant configuration. It integrates into your development workflows as a standalone CLI or as a node module.
MIT License
248 stars 155 forks source link

Fix preserve keywords in clientGrants audience #952

Closed kushalshit27 closed 2 months ago

kushalshit27 commented 2 months ago

🔧 Changes

When AUTH0_PRESERVE_KEYWORDS : true, exportoperation should preserve the mapping for audience key.

example:

clientGrants:
  - client_id: My Application
    audience: https://##AUTH0_DOMAIN##/api/v2/

📚 References

🔬 Testing

Added a new unit test cases to the main keyword preservation test with clientGrants resource.

📝 Checklist

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.33%. Comparing base (0ac0038) to head (f951152).

Files with missing lines Patch % Lines
src/context/yaml/handlers/clientGrants.ts 90.90% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #952 +/- ## ========================================== + Coverage 84.32% 84.33% +0.01% ========================================== Files 116 116 Lines 3802 3811 +9 Branches 745 748 +3 ========================================== + Hits 3206 3214 +8 Misses 329 329 - Partials 267 268 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kushalshit27 commented 2 months ago

Closing this now, as this fix is not enough, I will investigate later.