auth0 / auth0-deploy-cli

The Auth0 Deploy CLI is a tool that helps you manage your Auth0 tenant configuration. It integrates into your development workflows as a standalone CLI or as a node module.
MIT License
248 stars 155 forks source link

Formatted liquid templates fail in universal_login #971

Open zicvic opened 3 weeks ago

zicvic commented 3 weeks ago

Checklist

Description

When using a standard formatter for liquid code the deployment fails due to misalignment on expected formatting of the {%- auth0: head -%} and {%- auth0: widget -%} tags.

Expectation

When I use a standard formatter of the supported coding languages the deployment should not fail due to an additional space added to adhere to the formatting rules.

Reproduction

  1. Formatting the universal_login.liquid with these settings (in vscode):

    {
    "[liquid]": {
    "editor.defaultFormatter": "sissel.shopify-liquid",
    "editor.formatOnSave": true
    },
    "[liquid-css]": {
    "editor.defaultFormatter": "sissel.shopify-liquid",
    "editor.formatOnSave": true
    }
  2. Results in that the tags {%- auth0:head -%} and {%- auth0:widget -%} are re formatted to {%- auth0: head -%} and {%- auth0: widget -%} (notice added space)

  3. Running a0deploy import the results in this error message:

    2024-10-30T15:10:00.997Z - error: Problem running command deploy during stage processChanges when processing type branding
    2024-10-30T15:10:00.997Z - error: The template must contain a single auth0:head tag and at least one auth0:widget tag.
  4. Reformatting and removing the spaces results in a successful deployment

Deploy CLI version

7.23.4

Node version

v20.18.0

kushalshit27 commented 1 week ago

Hi, @zicvic , Thanks for opening this.

Its seem like the syntax is defined via API

This is not a valid syntax (with added space)

{%- auth0: widget -%}